Merge pull request #13 from sundowndev/test/analysis

Add missing tests for analysis pkg

lib/analysis/analysis_test.go

@@ -0,0 +1,69 @@
+//go:build !windows
+
+package analysis
+
+import (
+	"bytes"
+	"github.com/stretchr/testify/assert"
+	"github.com/sundowndev/covermyass/v2/mocks"
+	"os"
+	"testing"
+)
+
+func TestAnalysis_Write(t *testing.T) {
+	fakeCheck := &mocks.Check{}
+
+	testcases := []struct {
+		name     string
+		filename string
+		results  []Result
+	}{
+		{
+			name:     "test valid analysis",
+			filename: "testdata/valid_analysis.txt",
+			results: []Result{
+				{
+					Path:     "/var/log/dummy.log",
+					Size:     int64(32),
+					Mode:     os.ModePerm,
+					ReadOnly: false,
+					Check:    fakeCheck,
+				},
+				{
+					Path:     "/var/log/dummy2.log",
+					Size:     int64(8),
+					Mode:     600,
+					ReadOnly: true,
+					Check:    fakeCheck,
+				},
+			},
+		},
+		{
+			name:     "test empty analysis",
+			filename: "testdata/empty_analysis.txt",
+			results:  []Result{},
+		},
+	}
+
+	for _, tt := range testcases {
+		t.Run(tt.name, func(t *testing.T) {
+			testdata, err := os.ReadFile(tt.filename)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			a := NewAnalysis()
+			for _, r := range tt.results {
+				a.AddResult(r)
+			}
+			assert.Len(t, a.Results(), len(tt.results))
+
+			buffer := &bytes.Buffer{}
+			a.Write(buffer)
+
+			assert.Equal(t, string(testdata), buffer.String())
+		})
+	}
+
+	fakeCheck.AssertExpectations(t)
+}

lib/analysis/analyzer.go

@@ -14,10 +14,14 @@ import (
 
 type Analyzer struct {
 	filter filter.Filter
+	finder find.Finder
 }
 
 func NewAnalyzer(filterEngine filter.Filter) *Analyzer {
-	return &Analyzer{filterEngine}
+	return &Analyzer{
+		filterEngine,
+		find.New(os.DirFS(""), filterEngine),
+	}
 }
 
 func (a *Analyzer) Analyze() (*Analysis, error) {
@@ -31,8 +35,7 @@ func (a *Analyzer) Analyze() (*Analysis, error) {
 	for _, c := range check.GetAllChecks() {
 		wg.Add(1)
 		go func(c check.Check) {
-			finder := find.New(os.DirFS(""), a.filter)
-			results, err := finder.Run(context.TODO(), c.Paths())
+			results, err := a.finder.Run(context.TODO(), c.Paths())
 			if err != nil {
 				logrus.Error(err)
 				return

lib/analysis/testdata/empty_analysis.txt

@@ -0,0 +1,2 @@
+Summary
+Found 0 files (0 read-write, 0 read-only) in 0s

lib/analysis/testdata/valid_analysis.txt

@@ -0,0 +1,6 @@
+Found the following files
+/var/log/dummy.log (32 B, -rwxrwxrwx)
+/var/log/dummy2.log (8 B, ---x-wx---)
+
+Summary
+Found 2 files (1 read-write, 1 read-only) in 0s