fix: ovh error handling

lib/remote/suppliers/ovh.go

@@ -2,6 +2,7 @@ package suppliers
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"github.com/sundowndev/phoneinfoga/v2/lib/number"
 	"net/http"
@@ -15,15 +16,19 @@ type OVHSupplierInterface interface {
 
 // OVHAPIResponseNumber is a type that describes an OVH number range
 type OVHAPIResponseNumber struct {
-	MatchingCriteria    interface{}
-	City                string
-	ZneList             []string
-	InternationalNumber string
-	Country             string
-	AskedCity           interface{}
-	ZipCode             string
-	Number              string
-	Prefix              int
+	MatchingCriteria    interface{} `json:"matchingCriteria"`
+	City                string      `json:"city"`
+	ZneList             []string    `json:"zne-list"`
+	InternationalNumber string      `json:"internationalNumber"`
+	Country             string      `json:"country"`
+	AskedCity           interface{} `json:"askedCity"`
+	ZipCode             string      `json:"zipCode"`
+	Number              string      `json:"number"`
+	Prefix              int         `json:"prefix"`
+}
+
+type OVHAPIErrorResponse struct {
+	Message string `json:"message"`
 }
 
 // OVHScannerResponse is the OVH scanner response
@@ -54,6 +59,15 @@ func (s *OVHSupplier) Search(num number.Number) (*OVHScannerResponse, error) {
 	}
 	defer response.Body.Close()
 
+	if response.StatusCode >= 400 {
+		var result OVHAPIErrorResponse
+		err = json.NewDecoder(response.Body).Decode(&result)
+		if err != nil {
+			return nil, err
+		}
+		return nil, errors.New(result.Message)
+	}
+
 	// Fill the response with the data from the JSON
 	var results []OVHAPIResponseNumber
 

lib/remote/suppliers/ovh_test.go

@@ -72,11 +72,20 @@ func TestOVHSupplierError(t *testing.T) {
 func TestOVHSupplierCountryCodeError(t *testing.T) {
 	defer gock.Off() // Flush pending mocks after test execution
 
-	num, _ := number.NewNumber("15556661212")
+	gock.New("https://api.ovh.com").
+		Get("/1.0/telephony/number/detailedZones").
+		MatchParam("country", "co").
+		Reply(400).
+		JSON(OVHAPIErrorResponse{Message: "[country] Given data (co) does not belong to the NumberCountryEnum enumeration"})
+
+	num, err := number.NewNumber("+575556661212")
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	s := NewOVHSupplier()
 
 	got, err := s.Search(*num)
 	assert.Nil(t, got)
-	assert.EqualError(t, err, "country code +1 wasn't recognized")
+	assert.EqualError(t, err, "[country] Given data (co) does not belong to the NumberCountryEnum enumeration")
 }