-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the request for numverify scan #1072
Update the request for numverify scan #1072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to fix this 🙏🏻
You just need to fix tests now, feel free to ask if you need help on that.
@sundowndev I updated the tests to match the new URLs. However, the tests are failing, maybe because of the API keys. Can you please pull this branch and check what needs to be done. |
Hey @kriss-u I took a look and it seems that the Go http lib transforms the header key to camel case, so the Change this in the tests and it should pass : - MatchHeader("apikey", "...").
+ MatchHeader("Apikey", "..."). |
@sundowndev It should work now. I had also forgotten to change the server test to mock the response. The tests didn't fail afterwards. Thanks for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spending time on this 🙏🏻 ❤️
Previously, the API endpoint to perform a numverify scan was as follows.
This has been changed to the following.
I still don't know why the previous endpoint gets a hit and returns a response but doesn't do the verification job. The following is the screenshot after making the change. No automation tests are run.
Resolves #1056