TypeArguments: eliminate StackOverflow while retaining accurate types #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333.
While the original fix replaced the recursive mapping
V -> List<V>
withV -> List<?>
, here I take a more subtle approach. The mapping is replaced withV -> List<V>[replaced=true]
, where he[replaced=true]
is an attribute. The visitor never replaces class refs with this attribute and while doing so also removes it, so that the resulting type tree is clean.Because the goal of this is to be usable in
crd-generator
, I also added a new convenience methodRichTypeDef apply(ClassRef)
(I actually renamed a pre-existing private method with the same name to make room for it). This can process the types all the way from a generic reference (as opposed to from a definition)Related: fabric8io/kubernetes-client#4357