Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix>(lombok): add lombok @Data & fix @Setter #439

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

xiaoma20082008
Copy link
Contributor

just see the code

Copy link
Collaborator

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel added the downstream-check Run the downstream check workflow for this Pull Request label Oct 27, 2023
@xiaoma20082008
Copy link
Contributor Author

@iocanel
Please review again and I had added tests and fixed docs, thank you.

@iocanel iocanel self-requested a review October 27, 2023 16:41
Copy link
Collaborator

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit 9411539 into sundrio:main Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downstream-check Run the downstream check workflow for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants