Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loongarch64 #58

Merged
merged 5 commits into from May 3, 2023
Merged

Update loongarch64 #58

merged 5 commits into from May 3, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Apr 30, 2023

Sync changes for LoongArch64 from v0.3.2 to v0.3.6.

@heiher
Copy link
Contributor Author

heiher commented May 1, 2023

cc @xen0n

Copy link

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but you could further help maintainability by including the hashes and short descriptions of the commits you're effectively "amending", in the commit message of your applicable commits.

heiher added 5 commits May 1, 2023 22:08
Amends historic commit 5401f11 ("Add <linux/attr.h> to the general module.")
Amends historic commit 527beaa ("Provide `_NSIG`, `kernel_sigset_t`,
and `kernel_sigaction`")
…lack it

Amends historic commit c27ea90 ("Don't define the `sa_restorer` field
on platforms which lack it")
Amends historic commit 0faf869 ("Update to Linux 6.3")
Amends historic commit cd48b03 ("Manually define the ext4 ioctl values")
@heiher
Copy link
Contributor Author

heiher commented May 1, 2023

The changes look good to me, but you could further help maintainability by including the hashes and short descriptions of the commits you're effectively "amending", in the commit message of your applicable commits.

Great suggestions! I have already implemented your advice by including the hashes and short descriptions of the amended commits in the commit message. Thank you for helping me improve the maintainabilty of the code.

Copy link

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunfishcode sunfishcode merged commit b401e19 into sunfishcode:main May 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants