Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename invalid_mut to without_provenance_mut #109

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

rice7th
Copy link
Contributor

@rice7th rice7th commented Feb 25, 2024

Plain rename made for newer nightlies.

Fixes sunfishcode/c-ward#122 too.

@rice7th rice7th changed the title Renamed invalid_mut to without_provenance_mut Rename invalid_mut to without_provenance_mut Feb 25, 2024
@sunfishcode
Copy link
Owner

Thanks! Could you also update rust-toolchain.toml to point to a nightly version that has the new names, and run cargo fmt?

@rice7th
Copy link
Contributor Author

rice7th commented Feb 26, 2024

Sure! Just give me around six hours when I am back from school.

@rice7th
Copy link
Contributor Author

rice7th commented Feb 26, 2024

@sunfishcode Done, for both PRs. If you encounter any problems caused by the version bump, please let me know!

@rice7th
Copy link
Contributor Author

rice7th commented Feb 26, 2024

EDIT: I am trying to fix all CI errors, but each time a new one pops out. It may require a bit of time to prepare the PR correctly.

@sunfishcode
Copy link
Owner

CI now passed! Thanks for fixing this, and the static muts too!

@sunfishcode sunfishcode merged commit 930eadc into sunfishcode:main Feb 26, 2024
5 checks passed
@sunfishcode
Copy link
Owner

This is now released in origin 0.18.0.

@rice7th
Copy link
Contributor Author

rice7th commented Feb 26, 2024

Absolutely no problem! Glad I can help for this awesome project =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no invalid_mut in ptr
2 participants