Couple of refactorings to make adding dynamic linker support easier #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-relocation is not actually initializing runtime state, but making it possible to safely run any code at all. When using a dynamic linker the dynamic linker needs to be relocated before it can do dynamic linking, but some of the runtime intialization needs to happen after dynamic linking when all static DSO's that use thread local storage are known.
Also move writing __stack_chk_guard earlier. This makes future refactorings easier.
Also move the TLS for spawned threads away from the stack to simplify the logic and possibly allow using the regular memory allocator for allocating the TLS block for all threads other than the main thread.
bjorn3
force-pushed
the
tls_dynlink_refactors
branch
from
0a1f246
to
71c6e84
Compare
sunfishcode
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Overall these changes look good; my main concern is that thread creation and cleanup look like they get more expensive. Currently thread creation is just mmap, mprotect, and clone. With these changes it looks like there will be two mmaps. Similarly, thread cleanup goes from one munmap to two.
Would it be feasible to keep initilaize_main separate from create, but factor out the redundant code into utility functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.