Switch from log to tracing #80
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr attempts to replace log with tracing in a way that is backwards compatible. However after staring at the code for a while I do start wondering if it's the best approach. Unfortunately the current implementation is kinda broken since log is called in init without being properly feature gated. I feel like it would be cleaner to just implement it in a somewhat backward incompatible way by removing the usage in init including the env_logger implementation and just add a log feature for users of the log crate. I don't think it make sense to have a breaking release just for logging but at the same time it something that should be done eventually.