Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

Removed config assertions #18

Merged
merged 1 commit into from
May 15, 2018

Conversation

cemremengu
Copy link
Contributor

Assertions in configuration part are preventing some of the options including specifying a connection string in connection or connectString for oracledb (only).

@codecov-io
Copy link

codecov-io commented May 13, 2018

Codecov Report

Merging #18 into master will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   75.49%   76.02%   +0.53%     
==========================================
  Files           5        5              
  Lines         151      146       -5     
==========================================
- Hits          114      111       -3     
+ Misses         37       35       -2
Impacted Files Coverage Δ
agent.js 100% <ø> (ø) ⬆️
lib/knex.js 79.82% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df9195...f21aa39. Read the comment docs.

@sunfuze sunfuze merged commit f21aa39 into sunfuze:master May 15, 2018
@cemremengu
Copy link
Contributor Author

🙏

@cemremengu cemremengu deleted the remove-config-assertions branch May 15, 2018 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants