Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill does not use the temporary_path #5

Closed
sunjay opened this issue Oct 22, 2017 · 0 comments
Closed

Fill does not use the temporary_path #5

sunjay opened this issue Oct 22, 2017 · 0 comments
Assignees
Milestone

Comments

@sunjay
Copy link
Owner

sunjay commented Oct 22, 2017

There is a TODO comment in the implementation for begin fill and end fill where this should be done. I think the best way to implement this is to actually just pass the temporary path into render_polygon, then add it to the polygon to render if it is not None. The lines right under the TODO comment will take care of rendering the actual path.

@sunjay sunjay closed this as completed in 416430b Oct 24, 2017
@sunjay sunjay added this to the 1.0.0 - MVP milestone Oct 29, 2017
@sunjay sunjay self-assigned this Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant