Crash on macOS

[skade]

There's a reported crash on macOS: https://www.reddit.com/r/rust/comments/88xt9a/turtle_crashes_on_macos/

While trying to reproduce, I got the following:

$ cargo run
thread 'main' panicked at 'bug: failed to send query even though renderer process was still running', /Users/skade/.cargo/registry/src/github.com-1ecc6299db9ec823/turtle-1.0.0-rc.1/src/renderer_process.rs:81:29
note: Run with `RUST_BACKTRACE=1` for a backtrace.

[sunjay]

Hi! Thanks for reporting this! I probably wouldn't have seen it otherwise. 😄

Could you provide more information about your computer and rust versions? Here are some of the things I'm looking for:

Rust Version (`rustc --verbose --version`): 
Turtle Version: 
Operating System Version:
Graphics Card: 
Cargo.lock file:
<paste here>

Does the example from the piston_window repository run? You can run it by downloading or cloning the piston_window repository and then running:

cargo run --example hello_piston

[stevepentland]

I can try it tonight when I’m home

[cuyler]

@sunjay Saw your post on twitter and had a free cycle to test:

Both work correctly with stable rust: 1.25.0
Turtle Version: 1.0.0-rc-1
OS: System Version: macOS 10.13.3 (17D102)
Kernel Version: Darwin 17.4.0
Boot Mode: Normal
Secure Virtual Memory: Enabled
System Integrity Protection: Enabled
Graphics Card: Graphics: Intel Iris Plus Graphics 650, Intel Iris Plus Graphics 650, Built-In
Cargo.lock file: Here

The piston_window example DOES NOT work with the rust nightly... thus probably why Turtle isn't working either.

The piston_window example fails with "allocator memory exhausted", Illegal instruction: 4

[sunjay]

@cuyler Thank you so much! I opened an issue in piston_window so the problem can be discussed there. It sounds like this is working on stable Rust, so I encourage anyone running into this issue to work on stable until this is fixed.

In the meantime, if anyone is able to debug this further and find a way to fix the issue, that would definitely be appreciated! 😄

[sunjay]

@crazymykl was kind enough to look into this. This issue can be closed once the issue in the piston_window repository is closed and we have updated our dependencies and verified the fix.

[cuyler]

I’ll verify this works this afternoon, when I get a few free moments.

[cuyler]

@sunjay I tested this against the fix in piston_window and everything appears to be working for both stable and nightly rust toolchains. The fix is really just a bump to the piston_window crate. The PR is here.

[sunjay]

Thanks! The build seems to be failing so we'll need to figure out why. I am happy to accept this once that is fixed. 😄

[sunjay]

Cross-posting from #80:

Hi! Thanks for attempting to solve this through this PR! It turns out that the solution is not as trivial as just bumping the piston version. They appear to have updated some dependencies in between their releases and that has blocked our ability to update to those versions. I do not actually know what is required to update successfully and since I do not have a Mac, I can't really spend time on this at the moment.

Over the past couple of weeks, I have pretty much given up on piston for the time being. If you or anyone else is still willing to look into this and get Mac support back, I am happy to merge a fix.

Hopefully we will be able to add complete cross-platform support back soon!

So basically, I don't know how to fix this and I don't have the resources (operating system, time, etc.) at the moment to look into it. To see exactly what went wrong, look at the PR comments in #80. I'm going to leave this issue open in order to track that the problem exists, but I won't personally be looking into the solution any time soon.

If you are willing to look into this, here are some hints that may help:

• Pretty much all the code that deals with piston is in renderer.rs: https://github.com/sunjay/turtle/blob/master/src/renderer.rs
• When this problem happened last time, we fixed it by configuring piston to not use srgb
• This worked for a while, but now it doesn't. Maybe we need to revert that and try the old approach again? We need something that will work on Windows, Mac and Ubuntu systems
• Maybe we need to switch away from piston? Given my comments above, I am totally willing to discuss this (comment below or in Address Limitations of PistonWindow, Glutin, and winit #49)

Who knows? Maybe this is actually a trivial fix and I just don't have a Mac to figure it out. Sorry for not being able to address this sooner!

[cuyler]

Honestly, I got super busy with other things and completely spaced this. I’ll put it back into my task rotation and see if I can make some sense out of it.

[sunjay]

Thank you! I really appreciate that!

[sunjay]

Sorry this took so long to get around to! I've updated piston_window to the latest version. Could someone with a Mac test to see if the library is working now?

1. Pull the master branch of turtle: https://github.com/sunjay/turtle
2. cargo run --example circle
3. cargo run --example maze

Let me know if everything looks good. Thanks! 😄

[cuyler]

👍 Both work as expected on MacOS Mojave 10.14.4.

[sunjay]

Awesome! Thank you for trying it out! Please don't hesitate to let me know if more issues come up. Opening a new issue is probably better than re-opening this one. 😄

Thanks everyone! 🎉