Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning Senders & Callers, Memory leak fix, return Aborthandle for intervals, various fixes & dependency updates #51

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

jracollins
Copy link
Contributor

Hi again @sunli829! 👋

Apologies for the large individual PR and list of changes - been meaning to create an upstream PR for a while for all of these features/fixes after using in production working off my fork.

This PR contains the following:

  • Ability to Clone Senders & Callers using dynclone
    • Removes wrapping of CallerFn in a Mutex
  • Adds Docs for Sender/Callers - Resolves Sender / Caller docu #44
  • Small refactor in Broker to use remove Box<dyn Any + Send> and use Sender directly - asked in Sender / Caller docu #44
  • Fixes infinitely growing slab for intervals (was causing OOM issues when using send_later repeatedly)
  • Returns AbortHandle for intervals/send_later so that creator can cancel before completion if desired without stopping actor
  • Changes ActorId to use usize rather than u64 - Resolves 32-bit platform error #41
  • Bumps dependencies to latest versions
  • Added Eq to compare Callers/Senders

@jracollins jracollins mentioned this pull request Jun 7, 2022
@sunli829 sunli829 merged commit be389f8 into sunli829:master Jun 8, 2022
@sunli829
Copy link
Owner

sunli829 commented Jun 8, 2022

@jracollins Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sender / Caller docu 32-bit platform error
2 participants