New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DirectorySource path handling is unexpected #23
Comments
This is also a regression from the previous API. Found when migrating older code. |
Thanks for figuring out this issue. I will look into it later. |
I'd recommend abandoning string-based prefix filtering and using Path throughout the whole impl instead. On 24 December 2015 10:13:27 CET, Ning Sun notifications@github.com wrote:
Sent from my phone. Please excuse my brevity. |
Until last time I looked into |
a.relative_from(b) is b.join(a). Not sure what you need prefix for. I'd like to try this if you give me a few days. I'm currently busy. On 24 December 2015 11:35:15 CET, Ning Sun notifications@github.com wrote:
Sent from my phone. Please excuse my brevity. |
Thanks Markus, then I will leave this to you. I'm getting something with higher priority too. On 12/24/2015 07:04 PM, Markus Unterwaditzer wrote:
|
@untitaker, this issue is fixed by @viraptor via #24. I will close this for now. If you were going to refactor the Thank you @viraptor @untitaker for tracking this issue and using this module! |
Merry christmas :) |
Merry Christmas and Happy new Year! On 12/25/2015 02:01 PM, Stanisław Pitucha wrote:
|
DirectorySource treats the path argument in a very literal way. Specifically if there's a file "templates/index.hbs", then
will register template "/index", but
will register template "index". I'd expect both to do the same thing (without initial slash), because the path points at the exact same directory.
The text was updated successfully, but these errors were encountered: