Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle templates set on IronErrors #39

Closed
untitaker opened this issue Mar 29, 2016 · 4 comments
Closed

Handle templates set on IronErrors #39

untitaker opened this issue Mar 29, 2016 · 4 comments
Labels
enhancement

Comments

@untitaker
Copy link
Contributor

Currently, modifying the response of an Err(IronError) to have a template is not processed by the AfterMiddleware in this package, and the response body stays empty.

To process errors as well, catch needs to implemented besides after.
@untitaker untitaker mentioned this issue Mar 29, 2016
Closed
@sunng87
Copy link
Owner

sunng87 commented Mar 30, 2016

This makes sense. I will add support for catch very soon.

sunng87 added a commit that referenced this issue Mar 30, 2016
@sunng87
(feat) also render on error branch [#39]
6b4867e
@sunng87 sunng87 mentioned this issue Mar 30, 2016
Merged
sunng87 added a commit that referenced this issue Mar 31, 2016
@sunng87
(feat) also render on error branch [#39]
e6c9f53
sunng87 added a commit that referenced this issue Apr 1, 2016
@sunng87
(feat) also render on error branch [#39]
5a51f43
@sunng87
Copy link
Owner

sunng87 commented Apr 1, 2016

Fixed in #40

@sunng87 sunng87 closed this as completed Apr 1, 2016
@sunng87
Copy link
Owner

sunng87 commented Apr 1, 2016

released in 0.15.0

@untitaker
Copy link
Contributor Author

Excellent, thank you!

On Thu, Mar 31, 2016 at 08:01:36PM -0700, Ning Sun wrote:

released in 0.15.0

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunng87 @untitaker