issue 529: simplify lifetime requirements #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovasoa
changed the title
|
@lovasoa Thank you for your effect on experimenting on this issue. There are some lint/test issues to address. The change is welcomed if it works for our test cases. |
|
Thank you ! Sorry, I had forgotten to update the code that was behind feature flags, it's done now :) |
|
It all passed. Thank you for this patch. It has reduced overall complexity of this library. I will prepare a 5.0 release with this, including other break changes. |
|
Thanks to you, @sunng87, for maintaining this library 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only type annotations needed to be fixed, all the code actually already supported rendering shorter-lived templates.
This fixes #529
This is a breaking change, but it makes this API useful in more contexts, and even simplifies it a bit with fewer lifetime annotations, so I think it's worth it.
@sunng87