pass client when getting PortalStore #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poudels14
force-pushed
the
master
branch
2 times, most recently
from
982b4e2
to
1788dc8
Compare
- this makes it possible to have different portalstore for
different clients. Since default names are used when creating
a portal, clients sharing a portalstore would lead to leaks
- portal can have associated state that gets dropped when portal
is closed like transaction, query plan, etc. so, add a field to
hold the state
|
@poudels14 good catch! this issue was introduced by my previous refactoring. By the way, do you think it's a good idea to make portalstore part of |
|
I provided an alternative approach in #140 |
|
hi @poudels14, I'm going to merge #140 as a solution for this issue. It should require minimal code change for existed users. And we can further enhance it if there are new issues found with that design. |
|
Sounds good! thanks for adding that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres doc says prepared statements and portals exist only within a session. So, when getting a portalstore, pass in a client so that store corresponding to that client can be returned. This makes it possible to have different portalstore for different clients. Since default names are used when creating a portal, clients sharing a portalstore would lead to leaks