Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scram: generate random nonce with one call #182

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Jun 1, 2024

This has two benefits:

  1. takes 1 lock instead of 18
  2. generates multiple bytes per internal random invocation

This has two benefits:
1. takes 1 lock instead of 18
2. generates multiple bytes per internal random invocation
Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 merged commit 2f4ee5f into sunng87:master Jun 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants