Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introducing handler factory #183

Merged
merged 3 commits into from
Jun 12, 2024
Merged

refactor: introducing handler factory #183

merged 3 commits into from
Jun 12, 2024

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented Jun 11, 2024

As we have more and more handlers, startup, simple query, extended query and now copy, with logical replication may come soon, the process_socket api may need to accept a lot of arguments and break every time we introduce a new handler.

This patch sunsets our previous MakeHandler api and updated it to the new factory based api for both:

  1. include all handler types in the API
  2. take a responsibility of MakeHandler to control whether all not to create a new handler on new connections.

@sunng87 sunng87 merged commit d8cbdd1 into master Jun 12, 2024
6 checks passed
@sunng87 sunng87 deleted the feature/handler-api branch June 12, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant