Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Promptable #63

Closed
pboling opened this issue Jun 7, 2022 · 5 comments
Closed

Feature: Promptable #63

pboling opened this issue Jun 7, 2022 · 5 comments

Comments

@pboling
Copy link
Contributor

pboling commented Jun 7, 2022

I use Actors to run complex business logic, often from console or a rake task. I'd love to be able to integrate prompts without needing to think about how to integrate.

It would only be a few lines of code either way, but it seems like a helpful enough ability to provide it to everyone.
https://github.com/piotrmurach/tty-prompt

One downside is adding a new dependency to this gem. If that's too big an ask, then I can make a plugem called service_actor-promptable

@sunny
Copy link
Owner

sunny commented Jun 7, 2022

Even though I really enjoy the tty-prompt library, I think it would make more sense to have this as an extra gem than to include the dependency for everybody.

Let me know if you hit any road bumps trying to integrate this tightly to the Actor gem. If that’s the case perhaps we can find ways to make the Actor gem more “pluggable”.

@pboling
Copy link
Contributor Author

pboling commented Jun 7, 2022

Actually the way it worked out it didn't end up as a dependency. Let me know what you think. If it still doesn't make sense I'll pull it into a separate repo and plugin gem.

@sunny
Copy link
Owner

sunny commented Jun 8, 2022

Nice how you integrated that without requiring the gem!

However, I still think this should rather be a different gem. I’m afraid that it would specialize Actor a bit too much into CLI. I’d be happy to add a section about it in the README, though, and describe all the interesting plugins like service_actor-rails.

@pboling
Copy link
Contributor Author

pboling commented Jun 8, 2022

Already started on it. Thanks! ❤️

@pboling pboling closed this as completed Jun 8, 2022
@pboling
Copy link
Contributor Author

pboling commented Jun 9, 2022

@sunny Done - https://github.com/pboling/service_actor-promptable Would love to have a mention in the README. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants