Fetch image from Wikimedia via MusicBrainz #49

dmcneary · 2020-12-02T02:07:55Z

resolves #44
(mostly)

I set up a fetch call to MusicBrainz, which I have working most of the time to grab an image and change the background. It scrapes an image from Wikimedia, as long as there is one available. Some bands, however, don't have any images on Wikimedia.

lib/sonice/public/script.js

sunny

Thank you for this Pull-Request, this is awesome! I've marked most of HoundCI's suggestions as resolved since they should be outdated now that #50 is merged.

Can you apply the suggestions and rebase on top of main? 🙏

lib/sonice/public/script.js

sunny · 2020-12-19T16:25:03Z

Hey @dmcneary, any chance you will have some time to look over the requested changes?

houndci-bot · 2020-12-21T19:40:32Z

lib/sonice/public/script.js

+                            const filename = 
+                              imageUrl.substring(imageUrl.lastIndexOf('/') + 1);
+                            imageUrl = 
+                              'https://commons.wikimedia.org/wiki/Special:Redirect/file/' + 


Line is too long.

houndci-bot · 2020-12-21T19:40:33Z

lib/sonice/public/script.js

+                        let commonsStub = 
+                          'https://commons.wikimedia.org/wiki/File:';
+                        if (imageUrl.startsWith(commonsStub)) {
+                            const filename = 


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2020-12-21T19:40:33Z

lib/sonice/public/script.js

+                const imagesArr = [];
+                for (let i = 0; i < relations.length; i++) {
+                    if (relations[i].type === 'image') {
+                        let imageUrl = relations[i].url.resource;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

lib/sonice/public/script.js

houndci-bot · 2020-12-21T19:40:33Z

lib/sonice/public/script.js

+  if (!artist) return callback();
+  cache = artistImage.cache;
+  artist = encodeURI(artist);
+  const getImageFromCache = 


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

I think that merging the main branch should make these hints disappear.

lib/sonice/public/script.js

houndci-bot · 2020-12-21T19:47:19Z

lib/sonice/public/script.js

+  var changeBackground = function(){
+    artistImage(currentSong.artist, function(url) {
+      $('body').background(url)
+    })


Missing semicolon.

houndci-bot · 2020-12-21T19:47:19Z

lib/sonice/public/script.js

+  // Change background on the body regularly
+  var changeBackground = function(){
+    artistImage(currentSong.artist, function(url) {
+      $('body').background(url)


Missing semicolon.

houndci-bot · 2020-12-21T19:47:19Z

lib/sonice/public/script.js

+  }
+
+  // Change background on the body regularly
+  var changeBackground = function(){


'changeBackground' was used before it was defined.

houndci-bot · 2020-12-21T19:47:19Z

lib/sonice/public/script.js

@@ -52,6 +122,16 @@ $(function() {

    if (artistChange || songChange)
      $('#vote').removeAttr('disabled').show()
+
+      if (artistChange)
+      changeBackground()


Expected '{' and instead saw 'changeBackground'.
Missing semicolon.

houndci-bot · 2020-12-21T19:47:19Z

lib/sonice/public/script.js

+                            const filename = 
+                              imageUrl.substring(imageUrl.lastIndexOf('/') + 1);
+                            imageUrl = 
+                        'https://commons.wikimedia.org/wiki/Special:Redirect/file/' + 


Line is too long.

Perhaps this can be in a variable nearer the top of the file, such as wikimediaUrlPrefix?

houndci-bot · 2020-12-21T19:47:19Z

lib/sonice/public/script.js

+                for (let i = 0; i < relations.length; i++) {
+                    if (relations[i].type === 'image') {
+                        let imageUrl = relations[i].url.resource;
+                        let commonsStub = 


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

dmcneary · 2020-12-21T19:48:31Z

Hey @sunny,

Been busy with finals. I refactored your suggestions, still some little complaints from CI but let me know what you think.

lib/sonice/public/script.js

sunny · 2020-12-22T09:04:20Z

lib/sonice/public/script.js

+  if (!artist) return callback();
+  cache = artistImage.cache;
+  artist = encodeURI(artist);
+  const getImageFromCache = 


I think that merging the main branch should make these hints disappear.

lib/sonice/public/script.js

sunny · 2020-12-22T09:07:15Z

lib/sonice/public/script.js

+                            const filename = 
+                              imageUrl.substring(imageUrl.lastIndexOf('/') + 1);
+                            imageUrl = 
+                        'https://commons.wikimedia.org/wiki/Special:Redirect/file/' + 


Perhaps this can be in a variable nearer the top of the file, such as wikimediaUrlPrefix?

lib/sonice/public/script.js

houndci-bot · 2020-12-22T20:38:26Z

lib/sonice/public/script.js

+  }
+
+  // Change background on the body regularly
+  var changeBackground = function () {


'changeBackground' was used before it was defined.

houndci-bot · 2020-12-22T20:38:26Z

lib/sonice/public/script.js

-      $('#vote').removeAttr('disabled').show()
+      $('#vote').removeAttr('disabled').show();
+
+    if (artistChange) changeBackground();


Expected '{' and instead saw 'changeBackground'.

houndci-bot · 2020-12-22T20:38:26Z

lib/sonice/public/script.js


    if (artistChange || songChange)
-      $('#vote').removeAttr('disabled').show()
+      $('#vote').removeAttr('disabled').show();


Expected '{' and instead saw '$'.

houndci-bot · 2020-12-22T20:38:27Z

lib/sonice/public/script.js

    else
-      $('title').text(artist + (artist && title ? ' — ' : '') + title)
+      $('title').text(artist + (artist && title ? ' — ' : '') + title);


Expected '{' and instead saw '$'.

houndci-bot · 2020-12-22T20:38:27Z

lib/sonice/public/script.js


    if (!title)
-      $('title').text('So nice')
+      $('title').text('So nice');


Expected '{' and instead saw '$'.

houndci-bot · 2020-12-22T20:38:28Z

lib/sonice/public/script.js

+        .then(res => res.json())
+        .then(data => {
+          const relations = data.relations;
+          const commonsStub =


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2020-12-22T20:38:28Z

lib/sonice/public/script.js

+      fetch(url)
+        .then(res => res.json())
+        .then(data => {
+          const relations = data.relations;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2020-12-22T20:38:28Z

lib/sonice/public/script.js

+        '?inc=url-rels&fmt=json';
+      fetch(url)
+        .then(res => res.json())
+        .then(data => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2020-12-22T20:38:28Z

lib/sonice/public/script.js

+        mbid +
+        '?inc=url-rels&fmt=json';
+      fetch(url)
+        .then(res => res.json())


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2020-12-22T20:38:28Z

lib/sonice/public/script.js

+      // (https://github.com/hugovk/now-playing-radiator)
+      const mbid = response.artist.mbid;
+      if (!mbid) return;
+      const url =


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

sunny · 2020-12-26T15:41:42Z

Don't know why houndci-bot is still complaining. Looks good to me! Great work, @dmcneary 🎉

David McNeary added 3 commits November 25, 2020 18:01

added background ajax code back into script.js

df7643d

Fetching images from MB works, sometimes

a94dd51

Fetching images from MB works

66aa903

houndci-bot reviewed Dec 2, 2020

View reviewed changes

sunny mentioned this pull request Dec 4, 2020

Create .jshintrc #50

Merged

sunny requested changes Dec 5, 2020

View reviewed changes

Saroumane mentioned this pull request Dec 19, 2020

sonice's executable "rake" conflicts with anyplayer #53

Closed

Refactored according to suggestions by sunny

f1f82cb

houndci-bot reviewed Dec 21, 2020

View reviewed changes

Refactored according to suggestions by Hound

c1c9219

houndci-bot reviewed Dec 21, 2020

View reviewed changes

sunny reviewed Dec 22, 2020

View reviewed changes

David McNeary added 3 commits December 22, 2020 12:09

Refactored script.js for better reading and less indentation

86dec68

Merge branch 'main' of github.com:sunny/so-nice into MBID-call

142f7f3

Added curly brace rules to JSHint config

d10c3ed

houndci-bot reviewed Dec 22, 2020

View reviewed changes

sunny merged commit 371ffc7 into sunny:main Dec 26, 2020

sunny mentioned this pull request Mar 19, 2021

Cover art not showing up #57

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fetch image from Wikimedia via MusicBrainz #49

Fetch image from Wikimedia via MusicBrainz #49

dmcneary commented Dec 2, 2020

sunny left a comment •

edited

Loading

sunny commented Dec 19, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

sunny Dec 22, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

houndci-bot Dec 21, 2020

sunny Dec 22, 2020

houndci-bot Dec 21, 2020

dmcneary commented Dec 21, 2020

sunny Dec 22, 2020

sunny Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

houndci-bot Dec 22, 2020

sunny commented Dec 26, 2020

Fetch image from Wikimedia via MusicBrainz #49

Fetch image from Wikimedia via MusicBrainz #49

Conversation

dmcneary commented Dec 2, 2020

sunny left a comment • edited Loading

Choose a reason for hiding this comment

sunny commented Dec 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmcneary commented Dec 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunny commented Dec 26, 2020

sunny left a comment •

edited

Loading