Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix asset names #719

Merged
merged 1 commit into from
Jul 1, 2023
Merged

chore: fix asset names #719

merged 1 commit into from
Jul 1, 2023

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jul 1, 2023 •
edited
Loading 

$ goreleaser --version
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    1.19.1
GitCommit:     6b46a1a6aa51e45bd281d55b6e5a2315ee82f643
GitTreeState:  false
BuildDate:     2023-06-29T12:55:30Z
BuiltBy:       goreleaser
GoVersion:     go1.20.5
Compiler:      gc
ModuleSum:     h1:MVAFo62jkj6/JflxruefIwfFTqNTeNtkT12Hab1o2Lk=
Platform:      darwin/arm64

AS IS

$ goreleaser release --clean --snapshot
  • starting release...
  • loading config file                              file=.goreleaser.yml
  • loading environment variables
  • getting and validating git state
    • building...                                    commit=915aa858471e5ea67fb195c0883d51b612bceae1 latest tag=v0.24.0
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=v0.24.0-SNAPSHOT-915aa85
  • checking distribution directory
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/kubecm_windows_386/kubecm.exe
    • building                                       binary=dist/kubecm_linux_arm64/kubecm
    • building                                       binary=dist/kubecm_linux_amd64_v1/kubecm
    • building                                       binary=dist/kubecm_darwin_amd64_v1/kubecm
    • building                                       binary=dist/kubecm_linux_386/kubecm
    • building                                       binary=dist/kubecm_windows_amd64_v1/kubecm.exe
    • building                                       binary=dist/kubecm_darwin_arm64/kubecm
    • took: 1m37s
  • archives
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Windows_i386.tar.gz
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Linux_x86_64.tar.gz
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Darwin_arm64.tar.gz
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Linux_arm64.tar.gz
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Windows_x86_64.tar.gz
    • creating                                       archive=dist/kubecm_ v0.24.0-SNAPSHOT-915aa85_Linux_i386.tar.gz
    • took: 5s
  • calculating checksums
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • release succeeded after 1m43s
  • thanks for using goreleaser!

Asset names includes a space.

$ ls dist | grep kubecm
kubecm_ v0.24.0-SNAPSHOT-915aa85_Darwin_arm64.tar.gz
kubecm_ v0.24.0-SNAPSHOT-915aa85_Darwin_x86_64.tar.gz
kubecm_ v0.24.0-SNAPSHOT-915aa85_Linux_arm64.tar.gz
kubecm_ v0.24.0-SNAPSHOT-915aa85_Linux_i386.tar.gz
kubecm_ v0.24.0-SNAPSHOT-915aa85_Linux_x86_64.tar.gz
kubecm_ v0.24.0-SNAPSHOT-915aa85_Windows_i386.tar.gz
kubecm_ v0.24.0-SNAPSHOT-915aa85_Windows_x86_64.tar.gz
kubecm_darwin_amd64_v1
kubecm_darwin_arm64
kubecm_linux_386
kubecm_linux_amd64_v1
kubecm_linux_arm64
kubecm_windows_386
kubecm_windows_amd64_v1

TO BE

$ goreleaser release --clean --snapshot
  • starting release...
  • loading config file                              file=.goreleaser.yml
  • loading environment variables
  • getting and validating git state
    • building...                                    commit=915aa858471e5ea67fb195c0883d51b612bceae1 latest tag=v0.24.0
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=v0.24.0-SNAPSHOT-915aa85
  • checking distribution directory
    • cleaning dist
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/kubecm_windows_386/kubecm.exe
    • building                                       binary=dist/kubecm_darwin_amd64_v1/kubecm
    • building                                       binary=dist/kubecm_linux_386/kubecm
    • building                                       binary=dist/kubecm_linux_arm64/kubecm
    • building                                       binary=dist/kubecm_windows_amd64_v1/kubecm.exe
    • building                                       binary=dist/kubecm_darwin_arm64/kubecm
    • building                                       binary=dist/kubecm_linux_amd64_v1/kubecm
    • took: 5s
  • archives
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Windows_i386.tar.gz
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Windows_x86_64.tar.gz
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Linux_i386.tar.gz
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Linux_x86_64.tar.gz
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Linux_arm64.tar.gz
    • creating                                       archive=dist/kubecm_v0.24.0-SNAPSHOT-915aa85_Darwin_arm64.tar.gz
    • took: 5s
  • calculating checksums
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • release succeeded after 11s
  • thanks for using goreleaser!

Asset names are good.

$ ls dist | grep kubecm                
kubecm_darwin_amd64_v1
kubecm_darwin_arm64
kubecm_linux_386
kubecm_linux_amd64_v1
kubecm_linux_arm64
kubecm_v0.24.0-SNAPSHOT-915aa85_Darwin_arm64.tar.gz
kubecm_v0.24.0-SNAPSHOT-915aa85_Darwin_x86_64.tar.gz
kubecm_v0.24.0-SNAPSHOT-915aa85_Linux_arm64.tar.gz
kubecm_v0.24.0-SNAPSHOT-915aa85_Linux_i386.tar.gz
kubecm_v0.24.0-SNAPSHOT-915aa85_Linux_x86_64.tar.gz
kubecm_v0.24.0-SNAPSHOT-915aa85_Windows_i386.tar.gz
kubecm_v0.24.0-SNAPSHOT-915aa85_Windows_x86_64.tar.gz
kubecm_windows_386
kubecm_windows_amd64_v1

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review July 1, 2023 03:49
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Jul 1, 2023
Closed
sunny0826
sunny0826 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution 🎆

@sunny0826
Copy link
Owner

@suzuki-shunsuke Thanks so much, I was struggling with this!

@sunny0826 sunny0826 merged commit 8149dda into sunny0826:master Jul 1, 2023
1 check passed
@suzuki-shunsuke suzuki-shunsuke deleted the fix-asset-names branch July 1, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunny0826 sunny0826 sunny0826 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suzuki-shunsuke @sunny0826