Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sherlock and array #17

Closed
wants to merge 2 commits into from
Closed

Sherlock and array #17

wants to merge 2 commits into from

Conversation

Mayank662
Copy link
Contributor

Added a hackerrank problem with solution in C++, Please review it.
Fixes #15

Copy link
Owner

@sunnysetia93 sunnysetia93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.
But I see you are not following how to submit code on this repo.
Please go through contributions.md once.

Add this program in the category in which it belongs.

  1. if its an array based question. create an Array folder in the directory (HackerRank_Problems/ProblemSolving/cppSolutions/)
  2. Then create a file named sherlockAndArray.cpp containing the code.
  3. No need to copy-paste the entire question from hacker-rank, just paste the link of question in comments above the code.
  4. add a starter code, how to call your function/class with desired params and then give the expected output in comments in the same line.
  5. Refer to this file:
    These practice will make your code readable and will be easier for other's to maintain in future.

@sunnysetia93
Copy link
Owner

Closing this as @Mayank662 you have created a new PR #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more Hackerrank problems with solutions | C++
2 participants