Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebars ablog translations (#80) #161

Merged
merged 5 commits into from Nov 15, 2022
Merged

Conversation

luis-henrix
Copy link
Contributor

This pull-request includes 2 commits:

I'm leaving this as a draft pull-request. Comments are welcome.

@luis-henrix
Copy link
Contributor Author

Hmm.. there's a failure in the PR checks. Any idea what that means?

@nabobalis
Copy link
Contributor

You can ignore sunpy.ablog (Stage 3 Tests py310-sphinxdev [linux]), that is something I need to fix.

For pre-commit.ci that means the PR has failed the style check, that can be fixed automatically by a bot if you so desire. Otherwise you will want to run the pre-commit locally.

@nabobalis
Copy link
Contributor

Thanks for the PR! I can test it if you want to see if it works? Is there something else you want do before this is ready?

@luis-henrix
Copy link
Contributor Author

luis-henrix commented Oct 3, 2022 via email

@nabobalis
Copy link
Contributor

Is there something else you want do before this is ready?
Actually, I had another local change I forgot to commit. Unfortunately, I won't be able to do that now -- I'll try to push it later today. It's simply an update to the documentation, that needs to be updated.

Take your time, there is no need to rush here!

@luis-henrix
Copy link
Contributor Author

Ok, I've just pushed the extra change I had. It's a trivial change, I believe. Just update documentation to use the correct file paths.

Please let me know if you see any issues with this pull-request, specially with the commit that fixes issue #80 which is the one I'm less comfortable with.

Signed-off-by: Luís Henriques <henrix@camandro.org>
Signed-off-by: Luís Henriques <henrix@camandro.org>
With commit 4aa0e52 ("moved files to correct place") the localization files
have been moved from 'ablog/locale/' to 'ablog/locales'.  Fix the documentation,
which still refers to the old path.

Signed-off-by: Luís Henriques <henrix@camandro.org>
@nabobalis nabobalis marked this pull request as ready for review November 14, 2022 23:29
@nabobalis
Copy link
Contributor

Sorry for not getting back sooner, as far as I can tell, it works!

Thank you very much.

@nabobalis nabobalis merged commit 301bb0f into sunpy:main Nov 15, 2022
nabobalis added a commit that referenced this pull request Nov 15, 2022
Co-authored-by: Luís Henriques <henrix@camandro.org>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants