Apply suggestions from code review

Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
sunpy · Apr 24, 2024 · 8ed4e5f · 8ed4e5f
1 parent d5eb23c
commit 8ed4e5f
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/ndcube/tests/test_ndcubesequence.py b/ndcube/tests/test_ndcubesequence.py
@@ -72,12 +72,11 @@ def test_slice_common_axis(ndc, item, expected_common_axis):
 
 @pytest.mark.parametrize("ndc, item, expected_shape",
                          (
-                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[1:7], (4, 1, 3, 4)),
-                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[1:7, 0], (1, 4)),
-                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[2:4], (4, 0, 3, 4)),
-                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[0:6], (4, 2, 3, 4)),
-                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[0:6, :, 0], (4, 2, 3)),
-                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[0::, 0, 0], (2,))
+                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[:, 1:7], (3, 2, (2, 3, 1), 4)),
+                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[0, 1:7], (3, (2, 3, 1), 4)),
+                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[:, 2:4], (2, 2, 1, 4)),
+                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[:, 0:6], (2, 2, 3, 4)),
+                             ("ndcubesequence_4c_ln_lt_l_cax1", np.s_[0, 0:6], (2, 3, 4)),
                          ),
                          indirect=("ndc",))
 def test_index_as_cube(ndc, item, expected_shape):