Implements deprecation warnings on dimensions

ndcube/ndcollection.py

@@ -102,7 +102,7 @@ def aligned_dimensions(self):
         If there are no aligned axes, returns None.
         """
         if self.aligned_axes is not None:
-            return np.asanyarray(self[self._first_key].dimensions, dtype=object)[
+            return np.asanyarray(self[self._first_key].shape, dtype=object)[
                 np.array(self.aligned_axes[self._first_key])
             ]
 
@@ -178,7 +178,7 @@ def _generate_collection_getitems(self, item):
         # and drop any aligned axes that are sliced out.
 
         # First, define empty lists of slice items to be applied to each cube in collection.
-        collection_items = [[slice(None)] * len(self[key].dimensions) for key in self]
+        collection_items = [[slice(None)] * len(self[key].shape) for key in self]
         # Define empty list to hold aligned axes dropped by the slicing.
         drop_aligned_axes_indices = []
 
@@ -275,7 +275,7 @@ def update(self, *args):
         first_old_aligned_axes = self.aligned_axes[self._first_key] if self.aligned_axes is not None else None
         first_new_aligned_axes = new_aligned_axes[new_keys[0]] if new_aligned_axes is not None else None
         collection_utils.assert_aligned_axes_compatible(
-            self[self._first_key].dimensions, new_data[0].dimensions,
+            self[self._first_key].shape, new_data[0].shape,
             first_old_aligned_axes, first_new_aligned_axes
         )
         # Update collection

ndcube/ndcube.py

@@ -414,9 +414,9 @@ def combined_wcs(self):
             CompoundLowLevelWCS(self.wcs.low_level_wcs, self._extra_coords.wcs, mapping=mapping)
         )
 
-    @deprecated(version='3.0.0', reason='Replaced by ndcube.NDCube.shape')
     @property
     def dimensions(self):
+        warnings.warn("Replaced by ndcube.NDCube.shape", NDCubeDeprecationWarning)
         return u.Quantity(self.data.shape, unit=u.pix)
 
     @property

ndcube/ndcube_sequence.py

@@ -1,12 +1,14 @@
 import copy
 import numbers
 import textwrap
+import warnings
 
 import numpy as np
 
 import astropy.units as u
 
 from ndcube import utils
+from ndcube.utils.exceptions import NDCubeDeprecationWarning
 from ndcube.visualization.descriptor import PlotterDescriptor
 
 
@@ -46,6 +48,7 @@ def dimensions(self):
         """
         The length of each axis including the sequence axis.
         """
+        warnings.warn("Replaced by ndcube.NDCubeSequence.shape", NDCubeDeprecationWarning)
         return tuple([d * u.pix for d in self._shape])
 
     @property