Update get_dependent_axes implementation. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
Mar 2, 2018
ndcube/utils/wcs.py
Outdated
| return dependent_data_axes | ||
|
|
||
|
|
||
| def get_dependent_wcs_axes(wcs_object, wcs_axis, missing_axis): |
There was a problem hiding this comment.
is missing_axis actually being used in this function?
There was a problem hiding this comment.
No. That's for the spot.
Just working on tests now.
This commit updates the API and implementation of get_dependent_axes() to use method closer to that which is due to be merged into astropy from glue. In doing so it fixes a bug in NDCube.axis_world_coords which occurred when there was a missing axis.
… axis_correlation_matri().
DanRyanIrish
force-pushed
the
axis_world_coords_fix
branch
from
42fdd54
to
d2e795f
Compare
Cadair
approved these changes
Mar 2, 2018
DanRyanIrish
added a commit
that referenced
this pull request
Mar 20, 2018
Update get_dependent_axes implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the API and implementation of
get_dependent_axes()to use method closer to that which is due to be merged intoastropyfromglue. In doing so it fixes a bug inNDCube.axis_world_coordswhich occurred when there was a missing axis.