Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2D plotting in NDCube using APE14 #188

Merged

Conversation

yashrsharma44
Copy link
Member

@yashrsharma44 yashrsharma44 commented Jul 20, 2019

This PR addresses the rewriting of plotting.py for 2D NDCube.

Note this PR only modifies the tests for 1D plotting instead of making code changes, as the plotting of 1D cube works as it was working earlier.

This PR requires astrofrog's PR #8885 and plotting support in SlicedLowLevelWCS PR #8980 to be merged before this code is merged.
The above issue was sorted.

Edit:
The plotting of NDCube can be operated in 3 ways. The checklist denotes the feature which is working.

  • Simple plotting - NDCube.plot().
  • Plotting with plot_axis_indices argument - This feature is failing due to the bug in NDCube master. More info
  • Plotting with axes_coordinates argument.

@pep8speaks
Copy link

pep8speaks commented Jul 20, 2019

Hello @yashrsharma44! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-20 14:52:06 UTC

@ghost
Copy link

ghost commented Jul 20, 2019

Thanks for the pull request @yashrsharma44!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • This pull request does not have a milestone assigned to it. Only maintainers can change this, so you don't need to worry about it. 😄
  • I didn't detect a changelog file in this pull request. Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

@DanRyanIrish DanRyanIrish merged commit 3837614 into sunpy:ape14_rewrite Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants