Add crop method to NDCubeSequence #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @DanRyanIrish! Thanks for updating this PR.
Comment last updated at 2021-11-10 20:29:05 UTC |
DanRyanIrish
force-pushed
the
crop_sequence
branch
from
54f3ff9
to
0aef4c2
Compare
DanRyanIrish
force-pushed
the
crop_sequence
branch
from
0aef4c2
to
c2adf6f
Compare
DanRyanIrish
commented
Aug 24, 2021
in its slice objects.
3 tasks
DanRyanIrish
commented
Sep 15, 2021
This is required as the NDCube crop methods in which it relies have been changed and merged since.
|
@nabobalis this PR is now ready for a review if you are interested in giving one. |
nabobalis
reviewed
Nov 4, 2021
nabobalis
reviewed
Nov 4, 2021
nabobalis
reviewed
Nov 4, 2021
nabobalis
reviewed
Nov 4, 2021
nabobalis
reviewed
Nov 4, 2021
nabobalis
approved these changes
Nov 5, 2021
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
DanRyanIrish
commented
Nov 10, 2021
|
@nabobalis all your comments have been addressed. So I'll merge this once the tests are passed. That will enable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
.cropand.crop_by_valuestoNDCubeSequence. It works by using theNDCubecrop infrastructure to determine the slice items the crop inputs would require. If not all slice items are the same, the min and max start and stop values from all cubes are used. The slice item is them applied to the sequence as a whole. The sequence axis is not sliced.Requires #472 to be merged first.
Fixes #