Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrects bug 535 #538

Merged
merged 5 commits into from Aug 26, 2022
Merged

corrects bug 535 #538

merged 5 commits into from Aug 26, 2022

Conversation

jmbhughes
Copy link
Contributor

@jmbhughes jmbhughes commented Aug 26, 2022

PR Description

Bug #535 identifies that an NDCollection without aligned_axes cannot be updated. This was because the assertion for compatible axes did not consider the scenario where aligned_axes were not being used. Thus, I updated the ncube.utils.colleciton.assert_aligned_axes_compatible and the ndcube.ndcollection.NDCollection.update methods to take this into account by checking for this explicitly. Tests were added for this and passed successfully.

@pep8speaks
Copy link

pep8speaks commented Aug 26, 2022

Hello @jmbhughes! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 264:80: E501 line too long (110 > 79 characters)
Line 265:80: E501 line too long (104 > 79 characters)
Line 272:80: E501 line too long (134 > 79 characters)

Line 140:80: E501 line too long (83 > 79 characters)

Line 153:80: E501 line too long (97 > 79 characters)
Line 154:80: E501 line too long (106 > 79 characters)
Line 155:80: E501 line too long (105 > 79 characters)
Line 158:80: E501 line too long (109 > 79 characters)
Line 164:80: E501 line too long (101 > 79 characters)
Line 165:80: E501 line too long (100 > 79 characters)

Comment last updated at 2022-08-26 10:18:33 UTC

@DanRyanIrish DanRyanIrish added this to the 2.0.3 milestone Aug 26, 2022
jmbhughes and others added 4 commits August 26, 2022 04:04
@DanRyanIrish DanRyanIrish merged commit 8602116 into sunpy:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants