Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds shape property to NDCube #684

Merged
merged 39 commits into from
Apr 24, 2024
Merged

Adds shape property to NDCube #684

merged 39 commits into from
Apr 24, 2024

Conversation

CyclingNinja
Copy link
Member

Deprecates the dimensions property

DanRyanIrish
DanRyanIrish requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@DanRyanIrish DanRyanIrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments regarding NDCubeSequence: As well as request changes, make NDCubeSequence.dimensions do this:

def dimensions(self):
    return tuple([d * u.pix for d in self._shape])

Also, create a .shape property that just returns self._shape.

It's possible this may cause breaks elsewhere...

ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved
ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved
ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved
CyclingNinja and others added 5 commits April 23, 2024 15:58
@CyclingNinja @DanRyanIrish
Update ndcube/ndcube_sequence.py
4e251f8 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@CyclingNinja @DanRyanIrish
Update ndcube/ndcube_sequence.py
6f18309 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@CyclingNinja @DanRyanIrish
Update ndcube/ndcube_sequence.py
859690b 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@CyclingNinja
Adds shape property to NDCubeSequence
4e58b82
@CyclingNinja
Adds exceptions package
9151f76
DanRyanIrish
DanRyanIrish requested changes Apr 24, 2024
View reviewed changes
ndcube/ndcube_sequence.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Apr 24, 2024
View reviewed changes
ndcube/ndcube.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Apr 24, 2024
View reviewed changes
ndcube/ndcube.py Outdated Show resolved Hide resolved
CyclingNinja and others added 6 commits April 24, 2024 10:11
@CyclingNinja @nabobalis
Update ndcube/utils/exceptions.py
9176883 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @nabobalis
Update ndcube/utils/exceptions.py
237a349 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @DanRyanIrish
Update ndcube/ndcube_sequence.py
b3067b5 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@CyclingNinja @nabobalis
Update ndcube/ndcube.py
5f9d832 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @nabobalis
Update ndcube/ndcube.py
616c111 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja
Merge branch 'main' of github.com:sunpy/ndcube into remove_dimension
8ead4c7
nabobalis
nabobalis reviewed Apr 24, 2024
View reviewed changes
ndcube/ndcube.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Apr 24, 2024
View reviewed changes
ndcube/ndcube.py Outdated Show resolved Hide resolved
@nabobalis nabobalis added this to the 2.3.0 milestone Apr 24, 2024
@CyclingNinja @nabobalis
Implements new shape property on class
2d66db6 
Depricates `dimensions` property
CyclingNinja and others added 7 commits April 24, 2024 11:29
@CyclingNinja @nabobalis
Update ndcube/utils/exceptions.py
b941d22 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @nabobalis
Update ndcube/utils/exceptions.py
ca9c8b2 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @DanRyanIrish @nabobalis
Update ndcube/ndcube_sequence.py
2c5542f 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@CyclingNinja @nabobalis
Update ndcube/ndcube.py
e64670a 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @nabobalis
Update ndcube/ndcube.py
59d2e30 
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@CyclingNinja @nabobalis
Implements deprecation warnings on dimensions
e186d53
@nabobalis
add changelog
69d2cf1
@nabobalis nabobalis closed this Apr 24, 2024
@nabobalis nabobalis reopened this Apr 24, 2024
DanRyanIrish
DanRyanIrish requested changes Apr 24, 2024
View reviewed changes
ndcube/tests/test_ndcubesequence.py Outdated Show resolved Hide resolved
ndcube/tests/test_ndcubesequence.py Outdated Show resolved Hide resolved
ndcube/tests/test_ndcubesequence.py Outdated Show resolved Hide resolved
ndcube/tests/test_ndcubesequence.py Outdated Show resolved Hide resolved
ndcube/tests/test_ndcubesequence.py Outdated Show resolved Hide resolved
ndcube/tests/test_ndcubesequence.py Outdated Show resolved Hide resolved
@nabobalis @DanRyanIrish
Apply suggestions from code review
8ed4e5f 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@DanRyanIrish DanRyanIrish merged commit 6d1473c into sunpy:main Apr 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis left review comments

@DanRyanIrish DanRyanIrish DanRyanIrish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CyclingNinja @nabobalis @DanRyanIrish