Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add ilofar #57

Merged
merged 9 commits into from Nov 18, 2023
Merged

Feat add ilofar #57

merged 9 commits into from Nov 18, 2023

Conversation

samaloney
Copy link
Contributor

@samaloney samaloney commented Sep 20, 2021

Description

This PR depends on #54

The PR adds a Fido client and Spectrogram class for ILOFAR mode 357 observations. It maybe this is too niche for this package but I'm not sure where else to put it feedback on this welcome.

@samaloney samaloney force-pushed the feat-add-ilofar branch 3 times, most recently from 768a892 to 0495714 Compare September 20, 2021 12:06
@samaloney
Copy link
Contributor Author

If/when #54 is merged I'll rebase and remove the extra commits from this PR

@samaloney samaloney force-pushed the feat-add-ilofar branch 2 times, most recently from ea6229c to ac553d1 Compare September 22, 2021 21:19
Shane Maloney added 6 commits November 10, 2022 18:32
* BST files with 01 at the end are not valid so ignore in fido client
* Remove duble entry of polarisation data from client results
* BST files can be corrupt, try to detect and use intact part of file in spectrogram
@nabobalis nabobalis marked this pull request as ready for review November 11, 2022 02:45
@nabobalis nabobalis added this to the 0.5.0 milestone Nov 15, 2022
@samaloney samaloney marked this pull request as draft November 16, 2022 08:17
@sunpy sunpy deleted a comment from pep8speaks Nov 18, 2023
@nabobalis nabobalis marked this pull request as ready for review November 18, 2023 01:50
@nabobalis nabobalis force-pushed the feat-add-ilofar branch 2 times, most recently from 52e96fd to fc75a87 Compare November 18, 2023 01:59
@nabobalis nabobalis force-pushed the feat-add-ilofar branch 3 times, most recently from 48110d8 to fe59bd6 Compare November 18, 2023 16:44
@nabobalis nabobalis merged commit d14dae2 into sunpy:main Nov 18, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants