New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SOLO RPW spectrogram support #62
Conversation
b7d1bde
to
302ddd9
Compare
This code doesn't work on all RPW spectra need to test if any of acg1 or acg2 and use one or both accordingly |
420255d
to
83e2d67
Compare
5a81119
to
4548bed
Compare
freqs.append(cfreq) | ||
return slices, times, freqs | ||
|
||
sensor_unique = np.unique(sensor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the correct thing to be indexing?
Is the idea to find CH1 and CH2 here?
f8ad0da
to
c4aa519
Compare
Probably want more source tests? |
c4aa519
to
cf5c1d4
Compare
Online fail is very real. |
cf5c1d4
to
3cb8127
Compare
@@ -19,6 +19,7 @@ def client(): | |||
return SWAVESClient() | |||
|
|||
|
|||
@pytest.mark.skip("Upstream data server removed") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it come back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope the job of processing/hosting has moved to a different group/institute and the data is now only available on the CDPP and I'm not sure how to search that via an API also I think the files are in CDF format another proprietary format .B3E
? I'll add another change log to document the removal of the server and hence code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we should remove these tests and the client for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I need to check where the data can be obtained and in what formats so want to leave the code until I figure that out, only skipped the tests for the CI really.
e1b65a7
to
7633dd6
Compare
Description
Fixes #55 adding support for some SOLO//RPW data