Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge in sunpy package template #111

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Merge in sunpy package template #111

merged 10 commits into from
Feb 13, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Feb 9, 2024

#yolo

@Cadair Cadair added the Run Publish Build wheels on a PR label Feb 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@4b77706). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage        ?   96.82%           
=======================================
  Files           ?        2           
  Lines           ?      126           
  Branches        ?        0           
=======================================
  Hits            ?      122           
  Misses          ?        4           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cadair Cadair added the Run Cron CI Run the cron CI jobs on a PR label Feb 13, 2024
@Cadair Cadair marked this pull request as ready for review February 13, 2024 10:57
@Cadair
Copy link
Member Author

Cadair commented Feb 13, 2024

@CyclingNinja you want to review this?

@Cadair Cadair mentioned this pull request Feb 13, 2024
Merged
@nabobalis
Copy link
Contributor

RTD config needs updating.

@Cadair
Copy link
Member Author

Cadair commented Feb 13, 2024

I am going to leave RTD till later, template first.

@Cadair Cadair merged commit 45aaddf into sunpy:main Feb 13, 2024
20 of 21 checks passed
@Cadair Cadair deleted the template branch February 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

@CyclingNinja CyclingNinja CyclingNinja approved these changes

Assignees
No one assigned
Labels
Run Cron CI Run the cron CI jobs on a PR Run Publish Build wheels on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cadair @codecov-commenter @nabobalis @CyclingNinja