Fix: makes extra functions from the trace module private #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will need to update the test files as they are now failing. |
nabobalis
reviewed
Mar 20, 2023
nabobalis
reviewed
Mar 20, 2023
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
|
I think this PR is ready to be merged now |
nabobalis
approved these changes
Mar 20, 2023
|
Thanks for the PR @Saksham-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the functions not mentioned in issue #134 from the all variable to make them private.