Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with sunpy 5.0rc1 #145

Closed
wants to merge 3 commits into from
Closed

Test with sunpy 5.0rc1 #145

wants to merge 3 commits into from

Conversation

dstansby
Copy link
Member

Thank you for contributing to SunPy

🚨 IMPORTANT 🚨

We know that working on code and submitting pull requests takes effort, and we appreciate your time.
Thank you.

Please be aware that everyone has to follow our code of conduct

Furthermore, you might need to check with your work place if you are allowed to contribute code

  • Please try to create an issue before creating a Pull Request.
  • Please use the following Git commit message style
    • Use the future tense ("Adds feature" not "Added feature")
    • Limit the first line to 72 characters or less

We have several automatic features that run when a pull request is open.
They can appear daunting but do not worry about them!
This a brief explanation of them.

β†‘πŸ‘† DELETE above before submitting πŸ‘†β†‘

PR Description

@nabobalis
Copy link
Contributor

Core tests pass. 38 will fail.

@dstansby dstansby closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants