Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some initial functionality #8

Merged
merged 17 commits into from
Mar 15, 2018
Merged

Some initial functionality #8

merged 17 commits into from
Mar 15, 2018

Conversation

wafels
Copy link
Member

@wafels wafels commented Feb 23, 2018

This PR contains some initial functionality, and is based on an expanded version of the offlimb enhancement example in the sunpy gallery. This PR also contains an implementation of the normalizing radial gradient filter of Morgan, Habbal & Woo, 2006, Sol. Phys., 236, 263.

@prateekiiest
Copy link

@wafels, could I get to see the IDL output of this implementation?

@wafels
Copy link
Member Author

wafels commented Mar 5, 2018

The function intensity_enhance does not have an equivalent IDL implementation in SolarSoft, as far as I know.

There is an implementation of the NRGF, and it is here:

http://heliodocs.com/php/xdoc_print.php?file=$SSW/packages/nrl/idl/nrlgen/display/nrgf.pro

However, this implementation includes a lot more extra stuff which is not described in the paper like looking for bad pixels before doing the processing. Functionality like this should be separated from the implementation of Equation (1) (see the paper https://arxiv.org/pdf/astro-ph/0602174.pdf for the equation). The function normalizing_radial_gradient_filter in the PR is intended to implement Equation (1) of the paper, and nothing else.

So I'd say that there are no Solarsoft/IDL equivalents of the implementations in the PR.

@wafels wafels closed this Mar 9, 2018
@wafels
Copy link
Member Author

wafels commented Mar 9, 2018

Closing PR so as not to waste CI cycles. Please continue to work on the code as need be!

@wafels wafels reopened this Mar 15, 2018
@wafels wafels merged commit bdde984 into sunpy:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants