Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix thick_fn upper bounds #115

Merged
merged 7 commits into from Oct 18, 2023
Merged

fix thick_fn upper bounds #115

merged 7 commits into from Oct 18, 2023
+35 −26

Conversation

settwi
Copy link
Contributor

@settwi settwi commented Sep 18, 2023

Fixes #112

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023 •
edited

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...spex/sunxspex_fitting/photon_models_for_fitting.py 23.68% <0.00%> (+12.87%) ⬆️

... and 14 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

samaloney
samaloney approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@samaloney samaloney left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just need to fix what ever pre-commit is complaining about

@settwi
Copy link
Contributor Author

settwi commented Oct 18, 2023

@samaloney i ran autopep8 --aggressive --in-place on the photon models file but pre-commit.ci is saying it's still failing. maybe it means a different file is failing the check? not sure.
also added a changelog.

@KriSun95 can you look at this when you have a chance?

@settwi
Copy link
Contributor Author

settwi commented Oct 18, 2023

pre-commit.ci autofix

pre-commit-ci bot and others added 3 commits October 18, 2023 17:23
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1bea14e 
for more information, see https://pre-commit.ci
@KriSun95
Update 115.bugfix.rst
3c9345e 
Tweaked changelog description.
@KriSun95
Update photon_models_for_fitting.py
64f0e25 
Tidied up two comments and made one an issue.
KriSun95
KriSun95 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@KriSun95 KriSun95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but necessary PR. Thanks!

@KriSun95 KriSun95 merged commit c71a61a into sunpy:master Oct 18, 2023
7 of 10 checks passed
@settwi settwi deleted the fix-thickfn branch October 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaloney samaloney samaloney approved these changes

@KriSun95 KriSun95 KriSun95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High-energy break of thick_fn should not be 150 keV
4 participants
@settwi @codecov-commenter @samaloney @KriSun95