Xspec gain #148
Draft
Xspec gain #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en when the gain is used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage ? 55.66%
=======================================
Files ? 20
Lines ? 3196
Branches ? 0
=======================================
Hits ? 1779
Misses ? 1417
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As described in #147 , this draft shows how the gain can be applied in
sunkit-spexas it is applied in XSPEC. More discussion is needed but this should be somewhere to comment on.We change the gain correction being applied to edit the photon axis grid of the SRM before the total count model calculation as opposed to the current behaviour where the gain is applied after the photon model is folded through the response.