count_rate2counts should be dealing with the average, so no need for integers #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 32.47% // Head: 54.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
===========================================
+ Coverage 32.47% 54.63% +22.16%
===========================================
Files 18 19 +1
Lines 3098 3115 +17
===========================================
+ Hits 1006 1702 +696
+ Misses 2092 1413 -679
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
samaloney
force-pushed
the
kris-floatModel
branch
from
691ad05
to
003d5ba
Compare
samaloney
approved these changes
Dec 8, 2022
…ast to int. This also acts weird sometimes
Co-authored-by: Shane Maloney <shane.maloney@dias.ie>
samaloney
force-pushed
the
kris-floatModel
branch
from
5b2764d
to
8e9dbcb
Compare
samaloney
approved these changes
Feb 16, 2023
settwi
pushed a commit
to settwi/sunkit-spex
that referenced
this pull request
Sep 18, 2023
…integers (sunpy#87) * count_rate2counts should be dealing with the average, so should not be cast to int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not right to cast model counts to integers since this is supposed to be the model average in the time range being looked at and so it can be a float, it is the count data that must be integers. Casting to integers the way I did can also cause weird value overflows.