Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chanti data urls #90

Merged
merged 2 commits into from Dec 8, 2022
Merged

Conversation

samaloney
Copy link
Collaborator

PR Description

Update Chanti .sav url in test to point to lmsal server rather than hesperia

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Base: 9.83% // Head: 32.47% // Increases project coverage by +22.63% 🎉

Coverage data is based on head (ace68cf) compared to base (c8d0e07).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #90       +/-   ##
===========================================
+ Coverage    9.83%   32.47%   +22.63%     
===========================================
  Files          17       18        +1     
  Lines        3081     3098       +17     
===========================================
+ Hits          303     1006      +703     
+ Misses       2778     2092      -686     
Impacted Files Coverage Δ
sunxspex/io.py 89.07% <ø> (+70.58%) ⬆️
sunxspex/sunxspex_fitting/rainbow_text.py 11.76% <0.00%> (ø)
sunxspex/sunxspex_fitting/likelihoods.py 48.57% <0.00%> (+5.71%) ⬆️
sunxspex/sunxspex_fitting/fitter.py 13.26% <0.00%> (+11.27%) ⬆️
...spex/sunxspex_fitting/photon_models_for_fitting.py 24.32% <0.00%> (+13.51%) ⬆️
sunxspex/constants.py 88.88% <0.00%> (+16.66%) ⬆️
sunxspex/integrate.py 96.00% <0.00%> (+72.00%) ⬆️
sunxspex/sunxspex_fitting/io.py 100.00% <0.00%> (+72.97%) ⬆️
sunxspex/emission.py 92.20% <0.00%> (+83.02%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samaloney samaloney force-pushed the change-chanti-data-urls branch 4 times, most recently from 0acd0e2 to 5f3d818 Compare December 8, 2022 11:19
Copy link
Member

@hayesla hayesla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now. In the future we could have a check to also look for hesperia data too when its back up and running to avoid this in the future (e.g. lmsal goes down).

But I guess long term we dont want to depend on these at all anywho

@samaloney
Copy link
Collaborator Author

Yea I agree, ideally not depend on internet server for test or at least use all the possible source lmsal, nasasoho and hesperia.

Also I just changed back to the main OpenAstronomy template repo as the PR I needed was merged there.

@samaloney samaloney merged commit 67509e3 into sunpy:master Dec 8, 2022
@samaloney samaloney deleted the change-chanti-data-urls branch December 8, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants