Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydata 0.15 #228

Merged
merged 27 commits into from
Mar 20, 2024
Merged

Pydata 0.15 #228

merged 27 commits into from
Mar 20, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Sep 15, 2023 •
edited
Loading

This does actually change a few things and some colouring. I don't really have time to run them all down now.

fixes #224
fixes #223

nabobalis
nabobalis previously approved these changes Sep 15, 2023
View reviewed changes
@Cadair Cadair mentioned this pull request Sep 18, 2023
Closed
@nabobalis nabobalis force-pushed the pydata_0.14 branch 2 times, most recently from 1132c55 to 42c0d66 Compare December 31, 2023 02:49
@nabobalis nabobalis mentioned this pull request Dec 31, 2023
Merged
nabobalis added a commit that referenced this pull request Dec 31, 2023
@nabobalis @Cadair
Pulled doc changes from #228 (#234)
dcf40a4 
* Make some updates for 0.14

* Add more packages to list

Fixes #227

* Add some more style

* Add more colours and testing element to test_package

* More work towards a sunpy colour scheme

* Precommit

* rando

* More tweaks to colors

* Copied from pydata

* Removed doc changes

* Remove update changes

* Fix nabil problems

* LMAO ROFL PARTY ROCK

---------

Co-authored-by: Stuart Mumford <stuart@cadair.com>
@nabobalis nabobalis force-pushed the pydata_0.14 branch 3 times, most recently from 473a0b0 to ccfaafb Compare January 1, 2024 00:22
@nabobalis
Copy link
Contributor

nabobalis commented Mar 7, 2024 •
edited
Loading

Current state of the last merge:

  • The navbar background is white on lightmode (grey on latest), makes navbar text unreadable.

  • Change pygments.org/styles on the light theme.

  • The button that toggles light/dark is highlighted with a full orange block when you mouse over it which looks a bit awkward

Can't replicate this (hopefully pydata theme fixed these):

  • The sidebar border disconnects from the navbar when you scroll (does not do this on latest)

  • The navbar bottom border is grey here, should be the theme orange, like the sidebar border.

@nabobalis
Copy link
Contributor

Fixes #223

@nabobalis
Copy link
Contributor

Fixes #216

pydata theme already uses the quansight-labs.github.io/accessible-pygments package and we select two themes that are from this.

@wtbarnes
Copy link
Member

wtbarnes commented Mar 7, 2024

I had just a quick scroll through it, using both the light and dark themes, but it looks great to me!

@Cadair
Copy link
Member Author

Cadair commented Mar 11, 2024 •
edited
Loading

I am not sure I am a massive fan of the new dark background colour in comparison to the old one?

image

@Cadair
Copy link
Member Author

Cadair commented Mar 11, 2024 •
edited
Loading

Other things I can spot:

  • the double underline for the things which support hoverref isn't ideal
  • The left side bar toggle button is misaligned in the nav bar
  • The top breadcrubs navigation is truncated (and not coloured) in the new build

@wtbarnes
Copy link
Member

Can you request changes to block on this? It has two approvals so in theory could be merged as is.

@nabobalis
Copy link
Contributor

nabobalis commented Mar 18, 2024 •
edited
Loading

Or these issues are moved to issues and are patched after this PR is released?

@wtbarnes
Copy link
Member

Or that as well. I'm fine with either. I'd prefer the latter if these fixes are not straightforward.

@Cadair
Copy link
Member Author

Cadair commented Mar 20, 2024

OK, I have addressed everything I would like to change, I have deliberately done it in small commits so that if people disagree with any of the stylistic choices we can easily undo.

@Cadair
Copy link
Member Author

Cadair commented Mar 20, 2024

It seems that the breadcrumbs stuff is an upstream change not in CSS, so I am happy to just leave that.

@nabobalis nabobalis merged commit 2634f6f into sunpy:main Mar 20, 2024
8 checks passed
@nabobalis nabobalis removed the request for review from wtbarnes March 20, 2024 15:13
@Cadair Cadair deleted the pydata_0.14 branch March 20, 2024 15:58
@Cadair
Copy link
Member Author

Cadair commented Mar 20, 2024

Thanks @nabobalis for the review and release. Thanks everyone else, sorry this took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

@wtbarnes wtbarnes wtbarnes approved these changes

@alasdairwilson alasdairwilson alasdairwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Cadair @nabobalis @wtbarnes @alasdairwilson