Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to the eclipse notebook #413

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Various fixes to the eclipse notebook #413

merged 4 commits into from
Apr 12, 2024

Conversation

ayshih
Copy link
Member

@ayshih ayshih commented Apr 12, 2024

  • Refactored away the dependency on photutils
  • Fixed the x/y confusion and polished some of the plotting
  • Extracted the GPS altitude from the EXIF metadata
  • Fixed the conflation of the lunar disk and the solar disk

The angular offset of Regulus matches better, but is still not great. However, we don't know how much lens distortion there is

@nabobalis
Copy link
Contributor

Do we want to add a comment saying the offset left over is likely to be distortion from the lens?

@nabobalis nabobalis merged commit 0126358 into sunpy:main Apr 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants