-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region of Interest Object #164
Labels
Effort High
Requires a large time investment
Feature Request
New feature wanted!
Package Intermediate
Requires some knowledge of the internal structure of SunPy
Priority Low
Slow action required
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ghost
assigned aringlis
Jun 27, 2012
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ghost
assigned dpshelio
Dec 10, 2012
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nabobalis
added
Priority Low
Slow action required
Effort High
Requires a large time investment
Package Intermediate
Requires some knowledge of the internal structure of SunPy
labels
Jan 22, 2019
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Astropy have one now: https://astropy-regions.readthedocs.io/en/stable/index.html We should investigate if this will work for us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Effort High
Requires a large time investment
Feature Request
New feature wanted!
Package Intermediate
Requires some knowledge of the internal structure of SunPy
Priority Low
Slow action required
It would be good to have a region of interest (ROI) object.
A ROI object would contain at least the following:
Example use case:
User uses HEK module to get a list of events for some time range.
BBox info/chain-code from HEK results are automatically converted to SunPy RegionOfInterest instances.
Those instances can then be drawn as overlays on a Map instance, using something like "aiamap.show(overlays=hek_events)"
Here are some possible ways I could imagine creating a new RegionOfInterest:
See an older GSoC project: https://openastronomy.org/gsoc/gsoc2018/#/projects?project=region_of_interest
Extra
More generally it would be good to have an HEK event class that holds event
information. That could be an ROI or EOI factory, that understand HEK or other type of outputs.
WIP about extra methods
Could contain a number of functions (methods), such as 'GROW' or 'SHRINK' or 'ROTATE'.
There are many different ways to perform a "grow" and a "shrink" operation; scipy has a set of these operators under the "morphology" module
http://docs.scipy.org/doc/scipy/reference/ndimage.html#module-scipy.ndimage.morphology
I suppose you could pick one method and say "This is the default method", but you are not guaranteed to end up with something like you thought you were going to get.
For example, the "shrink" operation may end up splitting one ROI in to two unconnected ROIs.
How will we handle that? Is this what the user wants? On saying that, there are probably ways to ensure that you only ever return a single region after a "shrink" operation, but such considerations veer quickly in to the domain of image manipulation and away from a simple ROI object. I'm not saying it shouldn't be done, I'm just saying it requires some experimentation first.
The text was updated successfully, but these errors were encountered: