Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some 'Edit on Github' links on the top of the documentation pages point to a non existing page (error 404) #2169

Closed
samaloney opened this issue Jun 30, 2017 · 4 comments
Closed

Some 'Edit on Github' links on the top of the documentation pages point to a non existing page (error 404) #2169

samaloney opened this issue Jun 30, 2017 · 4 comments
Labels
Documentation Affects the documentation Hacktoberfest Issues that could be the focus of GSoC or Hacktoberfests

Comments

@samaloney
Copy link
Contributor

So on this page the edit on git hub link (with the Github logo) in the header works but in this page it links to a non existent page leading to a 404
@samaloney samaloney changed the title Some 'Edit on Github' links on the top of the documet point to a non existing page (error 404) Some 'Edit on Github' links on the top of the documentation pages point to a non existing page (error 404) Jun 30, 2017
@samaloney
Copy link
Contributor Author

There must be flag or something to signal when to add link or not if you look here (at the bottom this time) the link works as expected and then here in the generated docs there is no link.

@dpshelio dpshelio added the Documentation Affects the documentation label Jul 2, 2017
@Cadair Cadair mentioned this issue Jul 2, 2017
Merged
This was referenced Jul 3, 2017
Closed
Closed
@swapsha96 swapsha96 mentioned this issue Jul 10, 2017
Closed
@nabobalis nabobalis added Hacktoberfest Issues that could be the focus of GSoC or Hacktoberfests Close(?) Potentially stale or out of date issues labels Oct 4, 2017
@samaloney
Copy link
Contributor Author

Seems to be fixed in on RTD latest

@nabobalis
Copy link
Contributor

Does not work on the versioned RTD versions.

@nabobalis nabobalis removed the Close(?) Potentially stale or out of date issues label Oct 13, 2017
@nabobalis
Copy link
Contributor

It works now that I backported #2614.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Affects the documentation Hacktoberfest Issues that could be the focus of GSoC or Hacktoberfests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dpshelio @nabobalis @samaloney