Fix XRSClient time in query results #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
added
0.8.x
Affects Release
|
Hello @Cadair! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 13, 2017 at 18:05 Hours UTC |
Cadair
force-pushed
the
xrsclient_table
branch
from
c2613ba
to
c80ebcd
Compare
nabobalis
reviewed
Dec 10, 2017
| uripath = urlsplit(uri).path | ||
|
|
||
| # Extract the yymmdd or yyyymmdd timestamp | ||
| datestamp = os.path.splitext(os.path.split(uripath)[1])[0][4:] |
There was a problem hiding this comment.
This should always be the case? Remove the first 4?
There was a problem hiding this comment.
yeah the filenames always start with go{satnum:02d} so always four char
dpshelio
approved these changes
Dec 12, 2017
| # Extract the yymmdd or yyyymmdd timestamp | ||
| datestamp = os.path.splitext(os.path.split(uripath)[1])[0][4:] | ||
|
|
||
| if int(datestamp) < 990115: |
There was a problem hiding this comment.
is that 1999-01-15? or is the number of seconds since computer existed? a comment would help for people when look that in a confusing way.
Cadair
force-pushed
the
xrsclient_table
branch
2 times, most recently
from
58bb396
to
4ca9c4e
Compare
Cadair
force-pushed
the
xrsclient_table
branch
from
4ca9c4e
to
3fcc201
Compare
|
Unrelated online test fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2335