Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to composite map #2745

Closed
Cadair opened this issue Sep 11, 2018 · 4 comments
Closed

Improvements to composite map #2745

Cadair opened this issue Sep 11, 2018 · 4 comments
Labels
Effort Medium Requires a moderate time investment Feature Request New feature wanted! map Affects the map submodule Package Intermediate Requires some knowledge of the internal structure of SunPy Priority Medium Non-urgent action required

Comments

@Cadair
Copy link
Member

Cadair commented Sep 11, 2018

Composite map really needs some upgrades, and seeing how some of them would be API breaking (the fist one on the following list especially so) we should probably do it before 1.0.

Things I can think of without actually looking over the code:

  1. The get_ and set_ methods should be changed to be properties.
  2. The contouring routines should use the WCSAxes support for overlaying contours in different coordinate systems.
  3. It should use reproject to automatically overplot two unaligned images
  4. It should use reproject to align any two arbitrary images with flux conservation for analysis

It is also worth having a larger discussion about where CompositeMap fits into our general roadmap. Maybe even with a long-term eye on ndcube.

@wafels ping
@Cadair Cadair added Feature Request New feature wanted! map Affects the map submodule labels Sep 11, 2018
@nabobalis
Copy link
Contributor

nabobalis commented Jan 22, 2019 •
edited

See #2696, #463, #218. Tho should we resolve #2150 first.

@nabobalis nabobalis added Priority High Rapid action required Effort Medium Requires a moderate time investment Package Intermediate Requires some knowledge of the internal structure of SunPy Package Novice Requires little knowledge of the internal structure of SunPy and removed Package Intermediate Requires some knowledge of the internal structure of SunPy labels Jan 22, 2019
@Cubostar

This comment has been minimized.

Sign in to view
@Cadair Cadair added Package Intermediate Requires some knowledge of the internal structure of SunPy and removed Package Novice Requires little knowledge of the internal structure of SunPy labels Sep 30, 2019
@wafels wafels mentioned this issue Apr 1, 2020
Closed
@Cadair Cadair added Priority Medium Non-urgent action required and removed Priority High Rapid action required labels Aug 6, 2020
@wtbarnes
Copy link
Member

Also see #4492

@kakirastern kakirastern mentioned this issue Oct 10, 2020
Open
@mwhv2 mwhv2 mentioned this issue Sep 9, 2022
Open
@wtbarnes
Copy link
Member

wtbarnes commented Oct 6, 2023

I'm closing this as it appears all of the original asks have been addressed by issues that are now closed. If anyone disagrees, feel free to reopen.

@wtbarnes wtbarnes closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort Medium Requires a moderate time investment Feature Request New feature wanted! map Affects the map submodule Package Intermediate Requires some knowledge of the internal structure of SunPy Priority Medium Non-urgent action required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Cadair @nabobalis @wtbarnes @Cubostar