Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should port the VSO post-search filtering code to work with Fido #3733

Open
Cadair opened this issue Jan 27, 2020 · 8 comments
Open

We should port the VSO post-search filtering code to work with Fido #3733

Cadair opened this issue Jan 27, 2020 · 8 comments
Labels
Effort Medium Requires a moderate time investment Feature Request New feature wanted! net Affects the net submodule Package Intermediate Requires some knowledge of the internal structure of SunPy Priority Low Slow action required

Comments

@Cadair
Copy link
Member

Cadair commented Jan 27, 2020

In VSO you can use attrs to filter the search results, we should port this to Fido.

@twentyse7en

This comment has been minimized.

@nabobalis nabobalis added Effort Medium Requires a moderate time investment Feature Request New feature wanted! net Affects the net submodule Package Intermediate Requires some knowledge of the internal structure of SunPy Priority Low Slow action required labels Feb 3, 2020
@aribalam

This comment has been minimized.

@nabobalis

This comment has been minimized.

@aribalam

This comment has been minimized.

@Cadair

This comment has been minimized.

@aribalam
Copy link
Contributor

@Cadair @nabobalis It might be really complicated to filter out queries as the data format varies hugely depending on the client. Moreover there are some issues regarding data returned by the VSOClient (as mentioned in #3833). The QueryResponseBlock list returned is unhashable and cannot be converted to a set which is necessary to remove duplicate queries. The only way I could think of implementing this if every client implements its own way of filtering out data (similar to what is done with attrubute walker). Any suggestions on this?

@nabobalis
Copy link
Contributor

Could we standardize the data format from each client?

@abhijeetmanhas
Copy link
Contributor

After #4011 is merged, I would like to work on it. Specifically we need to have filter for dataretreiver client responses and jsoc responses, similar to vso one. And then implement a search() method in UnifiedResponse which uses existing filters and merge responses from all clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort Medium Requires a moderate time investment Feature Request New feature wanted! net Affects the net submodule Package Intermediate Requires some knowledge of the internal structure of SunPy Priority Low Slow action required
Projects
None yet
Development

No branches or pull requests

5 participants