Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev figure tests broken #4342

Closed
dstansby opened this issue Jul 9, 2020 · 2 comments · Fixed by #4360
Closed

dev figure tests broken #4342

dstansby opened this issue Jul 9, 2020 · 2 comments · Fixed by #4360
Labels
Upstream Fix Required A fix needs to go upstream to another package

Comments

@dstansby
Copy link
Member

dstansby commented Jul 9, 2020

Just a heads up that two dev figure tests are broken, I'm 99% sure we're running into matplotlib/matplotlib#17867 so just need to wait for a mpl fix.
@dstansby dstansby added the Upstream Fix Required A fix needs to go upstream to another package label Jul 9, 2020
@dstansby dstansby mentioned this issue Jul 9, 2020
Merged
@dstansby
Copy link
Member Author

Should be fixed upstream, I'll re-run the master figure tests to see if we need to update any hashes to make the dev build pass.

@nabobalis nabobalis mentioned this issue Jul 15, 2020
Merged
@nabobalis
Copy link
Contributor

That did fix it. I have opened a PR fixing the hashes.

@dstansby dstansby mentioned this issue Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Upstream Fix Required A fix needs to go upstream to another package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

figure dev hash update
Fix dev figure tests dstansby/sunpy
2 participants
@nabobalis @dstansby