Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A cheat sheet for making PRs to sunpy? #5944

Open
hayesla opened this issue Mar 9, 2022 · 5 comments
Open

A cheat sheet for making PRs to sunpy? #5944

hayesla opened this issue Mar 9, 2022 · 5 comments
Labels
Discussion An issue opened for, or undergoing discussion. Feature Request New feature wanted! Infrastructure Issues or PRs that affect the CI or packaging of SunPy

Comments

@hayesla
Copy link
Member

hayesla commented Mar 9, 2022

Describe the feature

It had been a while since I made some PRs to sunpy, and found it tricky to remember everything you need to do (checks/tests/changelogs etc).

It is well documented in the documentation, however I feel like it would be really useful to have a "cheatsheet" or quick guide to making PRs, with the step-by-step guide on what you have to do laid out exactly. The steps could also then point to the more detailed documentation on the docs. This could also include a "what you should do it figure-tests are failing" or common issues.

I don't know what everyone thinks - but I really do feel like this will be helpful and less overwhelming when trying to contribute, especially for newcomers or people not contributing regularly

Proposed solution

Make one?

@hayesla hayesla added the Feature Request New feature wanted! label Mar 9, 2022
@wtbarnes
Copy link
Member

wtbarnes commented Mar 9, 2022

I wonder if this could be folded into the PR template itself, with maybe some links to the relevant parts of the dev guide.

@nabobalis
Copy link
Contributor

Maybe if we delete the current PR template and have a link to a docs page/cheat sheet?

astropy have this page: https://docs.astropy.org/en/latest/development/workflow/development_workflow.html

I think we link to it in the newcomers guide.

@nabobalis nabobalis added Infrastructure Issues or PRs that affect the CI or packaging of SunPy Discussion An issue opened for, or undergoing discussion. labels Apr 27, 2022
@mwhv2
Copy link
Contributor

mwhv2 commented Jul 26, 2022

Since starting with SunPy in January, I have been taking notes for myself on how to make PRs and how Github works since I was fairly new to it (still getting used to it). I have condensed the notes into a PR cheat sheet that I (try to) follow. I’d be happy to post it in a comment here or make a draft PR so everyone can add their thoughts.

@nabobalis
Copy link
Contributor

Either works for me.

@Cadair
Copy link
Member

Cadair commented Jul 26, 2022

That sounds great @mwhv2, A PR is probably easiest to comment on but either works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion An issue opened for, or undergoing discussion. Feature Request New feature wanted! Infrastructure Issues or PRs that affect the CI or packaging of SunPy
Projects
None yet
Development

No branches or pull requests

5 participants